Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/better templates #195

Merged
merged 24 commits into from
Nov 25, 2024
Merged

Fix/better templates #195

merged 24 commits into from
Nov 25, 2024

Conversation

IObert
Copy link
Collaborator

@IObert IObert commented Nov 13, 2024 •
edited by nokenwa
Loading

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@IObert IObert self-assigned this Nov 13, 2024
@IObert IObert requested a review from nokenwa November 13, 2024 12:08
@IObert IObert assigned nokenwa and unassigned IObert Nov 13, 2024
nokenwa
nokenwa approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@nokenwa nokenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to go through it all, but I tested flow and read through as much of the code as I could. Looks good.

Quick question about the Lookup stuff. Do you still do SMS pumping checks on whatsapp?? Whatsapp is immune to SMS Pumping right?

@IObert
Copy link
Collaborator Author

IObert commented Nov 25, 2024

Lookup is not part if this PR since it was for London only and won't make it's way to the main

Thanks for reviewing, I'll merge now

@IObert IObert merged commit 8fce744 into main Nov 25, 2024
1 check passed
@IObert IObert deleted the fix/betterTemplates branch November 25, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nokenwa nokenwa nokenwa approved these changes

Assignees

@nokenwa nokenwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IObert @nokenwa